metrics: add namespace label to allocation metrics #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notnoop
reviewed
Jun 18, 2019
There was a problem hiding this comment.
The changes look good overall but have few questions/suggestions inlined. Also, the failing static check in https://travis-ci.org/hashicorp/nomad/jobs/546949777 is relevant.
added 2 commits
June 18, 2019 14:15
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, add them to job summary metrics.
the resulting changes (current, in both open-source and enterprise) are:
resolves #5554 by adding the
namespacelabel to allnomad.client.allocs.*metrics. in addition to not discriminating by namespace, there was a bug where identical jobs in different namespaces would cause one metric to "shadow" another one.similarly, added a
namespacelabel to allnomad.nomad.job_summary.*metrics.