Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts ANSI terminal codes to HTML in logs #5620

Merged
merged 2 commits into from
May 6, 2019

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Apr 27, 2019

Haven't tested Windows, but might address #5603

Before:
Screenshot 2019-04-27 at 15 53 40
After:
Screenshot 2019-04-27 at 15 53 04

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks for jumping on this @Mongey!

A couple thoughts I have:

  1. Re-rendering the entire log with every update raises a yellow flag. With streaming logs, this re-render can be frequent, but since there is a max output size, it should be okay. It would just be nicer if this streamed somehow.
  2. Returning HTML from output changes the return type of that property, but since it's currently only used in the task-logs component this is fine. I'm just not sure if it would be better to move transformation into the task-logs component instead to get it closer to where the logs render.

Anyhoo, neither of these thoughts are enough to block merging this. I read through the diff as well as the new anser dependency and it looks good 👍

Thanks again!

@DingoEatingFuzz DingoEatingFuzz merged commit 63e5aea into hashicorp:master May 6, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants