Implemented interpolation of Job, Task group and Task Names in Service Name #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,9 @@ func (j *Job) Register(args *structs.JobRegisterRequest, reply *structs.JobRegis | |||
| if err := args.Job.Validate(); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| args.Job.ExpandAllServiceNames() | |||
There was a problem hiding this comment.
I would put a comment on this
|
LGTM Might be worth updating the nomad init output to the new name specification so people can see it |
diptanu
added a commit
that referenced
this pull request
Nov 27, 2015
Implemented interpolation of Job, Task group and Task Names in Service Name
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #499
This PR disables addition of the prefix
${job-name}-${task-group}-${task}to every Service Name. Users can add${JOB},${TASKGROUP},${TASK}and${BASE}to the service name and Nomad interpolates their appropriate values.