-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Bugs around dots in task/task-group/driver names #4994
Conversation
ea395e0
to
cc3bdf1
Compare
cc3bdf1
to
8909046
Compare
'model:allocation', | ||
'model:job', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll be glad to know new testing doesn't have needs
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had to work around this a few times as well 😬 - very straightforward implementation here though and 👍 nice table tests ✨.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
There is a repeated pattern in serializers in the UI code of using
Ember.get
to read properties off of potentially undefined objects. Unfortunately,Ember.get
doesn't perfectly match plain JavaScript in its allowance of property names: dots inEmber.get
paths are always treated as nesting, meanwhile, dots are valid characters in properties in JavaScript and therefore JSON.This PR adds a bunch of unit tests to the offending serializers to expose the bugs and then squashes all the bugs by removing this pattern.