Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: interpolate driver configurations #4843

Merged
merged 8 commits into from
Nov 16, 2018
Merged

client: interpolate driver configurations #4843

merged 8 commits into from
Nov 16, 2018

Conversation

schmichael
Copy link
Member

@schmichael schmichael commented Nov 6, 2018 •
edited
Loading

Also add missing SetDriverNetwork calls.

Just a little more work than we were hoping it'd be, but we now have hcl doing task config interpolation for us.

@schmichael schmichael requested a review from nickethier November 6, 2018 01:39
@schmichael schmichael requested a review from dadgar November 9, 2018 19:28
nickethier
nickethier approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@nickethier nickethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions. Happy to see this merge as is though. Great work!

client/allocrunner/taskrunner/task_runner.go Outdated Show resolved Hide resolved
client/allocrunner/taskrunner/task_runner.go Show resolved Hide resolved
client/driver/env/env_test.go Show resolved Hide resolved
@schmichael
Copy link
Member Author

Test failures unrelated and unfinished work being submitted in a new PR. Merging.

@schmichael schmichael merged commit b0dcbb7 into master Nov 16, 2018
@schmichael schmichael deleted the b-driver-env branch November 16, 2018 18:45
@cgbaker cgbaker mentioned this pull request Jan 7, 2019
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar left review comments

@apparentlymart apparentlymart apparentlymart left review comments

@nickethier nickethier nickethier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmichael @apparentlymart @nickethier @dadgar