Add a missing eval trigger reason #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
requested changes
Sep 24, 2018
nomad/worker.go
Outdated
| @@ -114,18 +114,23 @@ func (w *Worker) run() { | |||
|
|
|||
| // Check for a shutdown | |||
| if w.srv.IsShutdown() { | |||
| w.logger.Error(fmt.Sprintf("nacking eval ID %v because the server shutdown", eval.ID)) | |||
There was a problem hiding this comment.
Use new formatting style
w.logger.Error(snacking eval because the server is shutting down", "eval", eval)
Same for all
dadgar
force-pushed
the
b-failed-trigger-reason
branch
from
18bfd1e to
b3e8555
Compare
dadgar
approved these changes
Sep 25, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
failed-follow-upto the list of allowed eval trigger reasons in both system and generic scheduler