Parse CA certificate to catch more specific errors #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
approved these changes
May 29, 2018
dadgar
requested changes
May 29, 2018
helper/tlsutil/config.go
Outdated
| @@ -146,8 +147,18 @@ func (c *Config) AppendCA(pool *x509.CertPool) error { | |||
| return fmt.Errorf("Failed to read CA file: %v", err) | |||
| } | |||
|
|
|||
| block, _ := pem.Decode([]byte(data)) | |||
There was a problem hiding this comment.
The PEM file can have multiple certificates in it. You are only parsing the first. See: https://golang.org/src/crypto/x509/cert_pool.go?s=2791:2855#L102
There was a problem hiding this comment.
Good to know Decode only handles the first, expanding to handle multiple.
|
Changelog entry as well |
chelseakomlo
force-pushed
the
f-tls-parse-certs
branch
from
f3635c2 to
8e2da4e
Compare
dadgar
approved these changes
May 30, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.