Improved Client handling of failed RPCs #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
reviewed
Apr 4, 2018
| return true | ||
| } else if s == nil && o != nil || s != nil && o == nil { | ||
| return false | ||
| } |
There was a problem hiding this comment.
Can be shortened to if s == nil || o == nil { return s == o }
h/t to @chelseakomlo
schmichael
reviewed
Apr 5, 2018
| equal := servers.Equal(m.servers) | ||
|
|
||
| // Randomize the incoming servers | ||
| servers.shuffle() |
There was a problem hiding this comment.
Do you still want to shuffle if they're equal?
There was a problem hiding this comment.
Yeah otherwise we will have deterministic ordering through Consul discovery.
schmichael
approved these changes
Apr 5, 2018
Handle the ErrNoLeader case and apply slower retries. Also when we have missed the heartbeat retry aggressively, backing off after we have missed for more than 30 seconds.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of failed RPCs by:
being set from Consul.