Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit metrics for non-running tasks #3559

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Don't emit metrics for non-running tasks #3559

merged 2 commits into from
Nov 17, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Nov 16, 2017

This PR causes metrics for terminal tasks to no longer be emitted. It also
fixes an issue in which ephemeral metrics weren't being properly cleaned from
the Prometheus Sink.

Fixes #3474

Copy link
Contributor

@jippi jippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dadgar dadgar merged commit ea0eba6 into master Nov 17, 2017
@dadgar dadgar deleted the b-metrics branch November 17, 2017 18:33
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.7.0-rc3] prometheus telemetry keep emitting data for stopped allocations
3 participants