Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] service Parameter name default can result in illegal names that pass validate #3532

Closed
Justin-DynamicD opened this issue Nov 11, 2017 · 1 comment
Labels
theme/api HTTP API and SDK issues type/bug

Comments

@Justin-DynamicD
Copy link

Justin-DynamicD commented Nov 11, 2017

This is a clarification of an issue I opened earlier that was closed in Nomad 0.7.0.

Jobs, Groups and Tasks naming standards are distinct from naming standards when using the service stanza, which must adhere to RFC-1123 per: service parameters

This can cause a problem in the following scenario:

  1. create a job that uses an underscore in either job, group, or task name.
  2. Include the service stanza, but do not add a "name" parameter.
  3. run a nomad validate, this will pass
  4. do a nomad run, this will fail due to nomad attempting to auto-generate the name "job-group-task" which now contains underscores which are illegal in the service name.

Nomad validate, imho, should be able to catch this type of problem by not only checking declared values but also plug in the default values during it's test.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/api HTTP API and SDK issues type/bug
Projects
None yet
Development

No branches or pull requests

2 participants