Fix MemorySwappiness on Windows Docker #3187
Conversation
| // Windows does not support MemorySwap/MemorySwappiness #2193 | ||
| if runtime.GOOS == "windows" { | ||
| hostConfig.MemorySwap = 0 | ||
| hostConfig.MemorySwappiness = -1 |
There was a problem hiding this comment.
I think you have the 0 and -1 switched judging by the API docs here: https://docs.docker.com/engine/api/v1.31/#operation/ContainerUpdate (search for "swappiness")
There was a problem hiding this comment.
One would wish this was documented better :) I actually brought up a windows server and this is the only config that works. -1 disables snappiness since the valid inputs are 0-100 and MemorySwap has to be 0 as well since there is no support for any swap.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #3181