status commands handle uuid prefixes with hyphens #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
command/alloc_status.go
Outdated
| @@ -142,7 +142,7 @@ func (c *AllocStatusCommand) Run(args []string) int { | |||
| c.Ui.Error(fmt.Sprintf("Identifier must contain at least two characters.")) | |||
| return 1 | |||
| } | |||
| if len(allocID)%2 == 1 { | |||
| if hyphens := strings.Count(allocID, "-"); (len(allocID)-hyphens)%2 == 1 { | |||
There was a problem hiding this comment.
Maybe this is a good candidate for helpers.go?
command/eval_status.go
Outdated
| @@ -130,7 +130,7 @@ func (c *EvalStatusCommand) Run(args []string) int { | |||
| c.Ui.Error(fmt.Sprintf("Identifier must contain at least two characters.")) | |||
| return 1 | |||
| } | |||
| if len(evalID)%2 == 1 { | |||
| if hyphens := strings.Count(evalID, "-"); (len(evalID)-hyphens)%2 == 1 { | |||
There was a problem hiding this comment.
It might be good to write a test to validate this behavior/bug fix
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.