Redact Vault.Token from AgentSelf response. #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Config.Vault.Token is defined, /v1/agent/self will return the string `<redacted>`. If the token is not set, This endpoint will continue to return the empty string.
dadgar
reviewed
Aug 8, 2017
command/agent/agent_endpoint.go
Outdated
| self.Config = ac.(*Config) | ||
| } | ||
|
|
||
| if self.Config.Vault.Token != "" { |
There was a problem hiding this comment.
Can you just do nil handling just in case :)
if self.Config != nil && self.Config.Vault != nil && self.Config.Vault.Token != "" {
|
Good idea. This solution probably violates Law of Demeter, but feels like the right thing for a targeted fix. If there are any other cases where we need to redact config, we should probably hoist this logic up into |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Config.Vault.Token is defined, /v1/agent/self will return the string
<redacted>. If the token is not set, This endpoint will continue toreturn the empty string.