Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rkt: use %s instead of %q when interpolating env #2777

Merged
merged 2 commits into from
Jul 5, 2017
Merged

rkt: use %s instead of %q when interpolating env #2777

merged 2 commits into from
Jul 5, 2017

Conversation

schmichael
Copy link
Member

Fixes #2686

@dadgar
Copy link
Contributor

dadgar commented Jul 5, 2017

Assuming tested, LGTM. Changelog too!

@schmichael
Copy link
Member Author

Only manually tested, but yup!

@schmichael schmichael merged commit fb96b86 into master Jul 5, 2017
@schmichael schmichael deleted the b-2686-dont-escape-env branch July 5, 2017 16:43
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmichael @dadgar