Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script check flapping #2635

Closed
samber opened this issue May 11, 2017 · 4 comments
Closed

Script check flapping #2635

samber opened this issue May 11, 2017 · 4 comments

Comments

@samber
Copy link
Contributor

samber commented May 11, 2017

When I execute many times a nomad run of the same job file, without any change, my script check is registered, then deregistered, the registered, then deregistered...

Consul logs:

May 11 14:48:54 ip-10-42-31-160 consul[772]: 2017/05/11 14:48:54 [INFO] agent: Deregistered check 'fc2a94375ef72782c7ec678434e8eaca02d74ba3'
May 11 14:50:06 ip-10-42-31-160 consul[772]: 2017/05/11 14:50:06 [INFO] agent: Synced check 'fc2a94375ef72782c7ec678434e8eaca02d74ba3'
May 11 14:53:24 ip-10-42-31-160 consul[772]: 2017/05/11 14:53:24 [INFO] agent: Deregistered check 'fc2a94375ef72782c7ec678434e8eaca02d74ba3'
May 11 14:56:50 ip-10-42-31-160 consul[772]: 2017/05/11 14:56:50 [INFO] agent: Synced check 'fc2a94375ef72782c7ec678434e8eaca02d74ba3'

(please note the same CheckID)

Nomad check:

...
        check {
          name     = "testing"
          type     = "script"
          command  = "pwd"
          interval = "10s"
          timeout  = "2s"
        }
...

Nomad version

Tested on a local, fresh consul + nomad setup

$ consul version
Consul v0.8.2
$ nomad version
Nomad v0.5.6

Also tested with nomad 0.5.4 (+nomad 0.5.3 as cli): same issue.

@schmichael
Copy link
Member

Hi @samber, Nomad's Consul integration was recently extensively refactored due to bugs and performance issues in the 0.5.x code. See #2478 for details.

Would it be possible for you to test on master? A number of check flapping bugs have been fixed, but script checks are a bit unique.

linux_amd64.zip
windows_amd64.zip

@samber
Copy link
Contributor Author

samber commented May 12, 2017

Looks like it's working well with master branch, but please note #2637

@samber samber closed this as completed May 12, 2017
@schmichael
Copy link
Member

@samber Thanks for checking! Sorry you hit that new bug.

@schmichael schmichael added this to the v0.6.0 milestone May 12, 2017
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants