Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable delay after deregistering consul service, before killing task #2607

Closed
jemc opened this issue May 2, 2017 · 2 comments
Closed

Comments

@jemc
Copy link

jemc commented May 2, 2017

As of #2596, nomad deregisters any consul services associated with a task just before "soft"-killing the task. The task is expected to terminate itself within the configured kill_timeout or face a "hard" kill from nomad.

However, some solutions may have other components in a distributed system depending on those consul service deregistrations for making decisions, such as a web load balancer (like fabio, traefik, or HAProxy + consul-template) that forwards traffic to a pool of currently registered services. Being a distributed system, the changes do not propagate immediately, so the load balancer may end up sending some traffic to containers that have already disappeared (if their soft kill handling is faster than the time it takes the deregistration to propagate to the load balancer).

To facilitate this kind of use case, I want to propose adding a configurable delay between the time the consul services are deregistered and the time that nomad actually initiates the kill sequence for the task. This configurable delay would be zero by default, and thus would not affect existing solutions.

There has already been some discussion of this idea in #2596, but @schmichael has requested that we discuss the idea further in this ticket.

@schmichael
Copy link
Member

Just discovered this is a dupe of #2441

Closing to focus discussion over there.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants