Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node pool attribute to interpretable values in task env #24052

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

mismithhisler
Copy link
Member

@mismithhisler mismithhisler commented Sep 24, 2024

Added node.pool attribute to interpretable node attributes so it could be used as per the docs

Fixes: #24043

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget your changelog entry!

@mismithhisler mismithhisler merged commit 338487c into main Sep 24, 2024
26 checks passed
@mismithhisler mismithhisler deleted the b-add-nodepool-to-taskenv branch September 24, 2024 17:23
@tgross tgross added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line labels Sep 24, 2024
@tgross tgross added this to the 1.9.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node pool variable not working in task template
3 participants