[ui] Prevent double-open for cmd+click on jobs index links #23832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
philrenaud
force-pushed
the
23544-ui-cmdctrl-+-click-wont-correctly-open-new-tabs
branch
from
dd94539
to
47b3f25
Compare
philrenaud
deleted the
23544-ui-cmdctrl-+-click-wont-correctly-open-new-tabs
branch
This was referenced Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cmd+click (or ctrl+click) on the
<a>tag within job rows on the jobs index page would double-open the page: once in a new tab (as cmd+click does) and another in the same tab (as it would trigger the{{on "click"}}Ember event for the job row.This checks to make sure the clicked element wasn't the anchor tag itself, and if it is, it returns early.
NB: it's a bad practice, generally, to have non-interactive elements like table rows be clickable! However this follows a long-standing convention in the Nomad UI that users may be used to from years of use, and has more than one highly accessible fallback.
Resolves #23544