Tie allowed network modes to namespace capabilities. #23813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo13
force-pushed
the
network_mode_capabilities
branch
from
f004c02
to
a71617d
Compare
apollo13
commented
Aug 14, 2024
tgross
requested changes
Aug 15, 2024
There was a problem hiding this comment.
This looks great @apollo13! I've left some minor comments. We'll also need:
- Can you run
make clto add a changelog entry - Can you update the namespace specification docs as well? https://developer.hashicorp.com/nomad/docs/other-specifications/namespace
Just a heads up that I'm going to be out on vacation starting next week until September. I'll make sure someone else on the team has their eyes on this PR. But at worst I'll pick it back up and that'll be in time for Nomad 1.8.4.
Co-authored-by: Tim Gross <[email protected]>
Had one but fixed it up
done
Have fun :) |
tgross
reviewed
Aug 16, 2024
| { | ||
| "No drivers enabled/disabled, allow all", | ||
| "bridge", | ||
| &structs.Namespace{Capabilities: &structs.NamespaceCapabilities{}}, |
There was a problem hiding this comment.
I added this test case just for thoroughness.
tgross
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgross How does that look?