[ui] Fix: upload jobspec button #23548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
commented
Jul 11, 2024
| @@ -15,28 +15,26 @@ | |||
| <p> | |||
| Paste or author HCL or JSON to submit to your cluster, or select from a list of templates. A plan will be requested before the job is submitted. You can also attach a job spec by uploading a job file or dragging & dropping a file to the editor. | |||
| </p> | |||
|
|
|||
| {{#if (can "read variable" path="nomad/job-templates/*" namespace="*")}} | |||
There was a problem hiding this comment.
Psst: review this with "Hide Whitespace" enabled. This change makes it so that you can still upload a jobspec without the "read variables" ACL capability, which I had foolishly wrapped the upload button in before (it being next to the button that actually requires variable read access, "Choose from template")
Ember Test Audit comparison
|
pkazmierczak
approved these changes
Jul 11, 2024
philrenaud
force-pushed
the
b-ui/upload-jobspec-button-fix
branch
from
3355a01
to
6a41f72
Compare
martisah
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point recently, the upload jobspec button (on the Job Run page) stopped working and I've yet to find a good reason why.
The job editor component uses what's called a render modifier in Ember. It uses a library to help add syntactical sugar to do this.
(Modifier TLDR: it "modifies" an existing HTML element, like a
<div>in this case, instead of creating a new one in an Ember context. This is useful for codemirror, our text editor, because it needs to exist outside of an Ember context for lifecycle reasons)There's a lifecycle hook in modifiers written this way called
modify(), and there were previously ones calleddidUpdateArguments()anddidUpdateArguments(). Previously, we'd set this up to usedidUpdateArgumentsto let thecode-mirrormodifier, but per the library's migrations guide, this is/was being deprecated.Problem is,
modify()is a lifecycle hook that happens both on initial load and on content update and on external-attribute (like the "should word-wrap" property, etc.) and bundling everything intomodify()over-compounds this pattern a bit.This PR makes it so that we still use
didUpdateArguments(), but as a conditional method call frommodify().To test:
Head to the jobs index page, click "Run Job", click "Upload", and you should now see the text of your .hcl upload appear in the text editor. In previous (1.8.x anyway) versions this should not work.