[ui] Generalized namespace handling, generalized facet searching, node pools facet search #23468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks beautiful! LGTM. I won't approve because that is reserved for engineering! |
philrenaud
commented
Jun 28, 2024
| @@ -202,7 +195,7 @@ export default class JobsIndexController extends Controller { | |||
| * @param {Error} e | |||
| */ | |||
| notifyFetchError(e) { | |||
| const firstError = e.errors[0]; | |||
| const firstError = e.errors?.objectAt(0); | |||
There was a problem hiding this comment.
I should've caught this in #23427, but handling it here. Defensive logic in case there's an errors-less error (driving through a tunnel, etc.)
philrenaud
commented
Jun 28, 2024
| @@ -433,40 +426,38 @@ export default class JobsIndexController extends Controller { | |||
| label: 'NodePool', | |||
| options: (this.model.nodePools || []).map((nodePool) => ({ | |||
| key: nodePool.name, | |||
| string: `NodePool == ${nodePool.name}`, | |||
| string: `NodePool == "${nodePool.name}"`, | |||
There was a problem hiding this comment.
Fixes an issue reported in #23445
philrenaud
force-pushed
the
f-ui/NET-10159-Implement-the-namespace-drop-down-box-on-nomad-UI-as-a-list-of-check-boxes-not-a-list-of-radio-buttons
branch
from
441242d
to
885e836
Compare
philrenaud
force-pushed
the
f-ui/NET-10159-Implement-the-namespace-drop-down-box-on-nomad-UI-as-a-list-of-check-boxes-not-a-list-of-radio-buttons
branch
from
885e836
to
a01cde7
Compare
Ember Test Audit comparison
|
philrenaud
force-pushed
the
f-ui/NET-10159-Implement-the-namespace-drop-down-box-on-nomad-UI-as-a-list-of-check-boxes-not-a-list-of-radio-buttons
branch
from
e41e55f
to
82664c0
Compare
philrenaud
force-pushed
the
f-ui/NET-10159-Implement-the-namespace-drop-down-box-on-nomad-UI-as-a-list-of-check-boxes-not-a-list-of-radio-buttons
branch
from
82664c0
to
39552cd
Compare
philrenaud
requested review from
pkazmierczak and
Juanadelacuesta
and removed request for
schmichael and
shoenig
philrenaud
deleted the
f-ui/NET-10159-Implement-the-namespace-drop-down-box-on-nomad-UI-as-a-list-of-check-boxes-not-a-list-of-radio-buttons
branch
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the jobs index page's Namespaces dropdown from single select (radio buttons) to checkboxes (multiple OR-based selection)
Also fixes an error noted in #23445 where node pools and namespaces with
-characters would not filter correctlyResolves NET-10159