api: Add Notes field to service checks #22397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
requested changes
May 29, 2024
There was a problem hiding this comment.
Hey @nicoche, thanks for the PR! Looks good! I left some minor comments, could you have a look? Also, would you add a changelog file? You can use the make cl command to generate it.
| @@ -68,6 +68,7 @@ type ServiceCheck struct { | |||
| Interval time.Duration // Interval of the check | |||
| Timeout time.Duration // Timeout of the response from the check before consul fails the check | |||
| InitialStatus string // Initial status of the check | |||
| Notes string // Specifies arbitrary information for humans. This is not used by Consul internally | |||
There was a problem hiding this comment.
Do you think we could add a little validation on this field? Maybe we could at least limit the length of notes to 250 characters? There's already a method for validating Consul fields.
There was a problem hiding this comment.
Good idea, pushed a fix
This reverts commit bf4324cd6f23047c0fbe2fd799235261fa2068bb.
nicoche
force-pushed
the
21372-notes-on-checks
branch
from
bf4324c
to
7d921be
Compare
pkazmierczak
approved these changes
Jun 10, 2024
pkazmierczak
changed the title
pkazmierczak
added
backport/ent/1.8.x+ent
tgross
reviewed
Jun 10, 2024
Co-authored-by: Piotr Kazmierczak <[email protected]>
|
Thanks guys for checking. @pkazmierczak accepted your suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21372