Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job endpoint: fix implicit constraint mutation for task-level services #22229

Merged
merged 4 commits into from
May 23, 2024

Conversation

pkazmierczak
Copy link
Contributor

Fixes a regression in Nomad 1.7 which caused task-level services no longer having created implicit Consul constraints.

Resolves #22190

@pkazmierczak pkazmierczak self-assigned this May 23, 2024
@pkazmierczak pkazmierczak added backport/1.7.x backport to 1.7.x release line backport/ent/1.5.x+ent Changes are backported to 1.5.x+ent backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent labels May 23, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@pkazmierczak pkazmierczak removed backport/ent/1.5.x+ent Changes are backported to 1.5.x+ent backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent labels May 23, 2024
@pkazmierczak pkazmierczak merged commit f0851bc into main May 23, 2024
19 checks passed
@pkazmierczak pkazmierczak deleted the b-consul-task-service-constraint-missing branch May 23, 2024 17:27
@pkazmierczak pkazmierczak added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line and removed backport/1.7.x backport to 1.7.x release line labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: constraint attr.consul.version semver >= 1.7.0 is missing after nomad 1.7 update
2 participants