-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobs Index Page: Live Updates + Pagination #20452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
philrenaud
changed the title
Bff job summary fe redux (attempting to untangle)
Jobs Index Page: Live Updates + Pagination
Apr 18, 2024
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
from
April 30, 2024 20:13
cf94d52
to
7532eb7
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
from
May 2, 2024 17:58
baa42fe
to
3350ebc
Compare
gulducat
force-pushed
the
bff-accurate-jobs-summaries
branch
from
May 3, 2024 15:46
7d819dd
to
cb8a211
Compare
* modifyIndex-based pagination * modifyIndex gets its own column and pagination compacted with icons * A generic withPagination handler for mirage * Some live-PR changes * Pagination and button disabled tests * Job update handling tests for jobs index * assertion timeout in case of long setTimeouts * assert.timeouts down to 500ms * de-to-do * Clarifying comment and test descriptions
…he viz grow forever (#20458)
* Beginnings of a search box for filter expressions * jobSearchBox integration test * jobs list updateFilter initial test * Basic jobs list filtering tests * First attempt at side-by-side facets and search with a computed filter * Weirdly close to an iterative approach but checked isnt tracked properly * Big rework to make filter composition and decomposition work nicely with the url * Namespace facet dropdown added * NodePool facet dropdown added * hdsFacet for future testing and basic namespace filtering test * Namespace filter existence test * Status filtering * Node pool/dynamic facet test * Test patchups * Attempt at optimize test fix * Allocation re-load on optimize page explainer * The Big Un-Skip * Post-PR-review cleanup
…0493) * First pass at a non-watchQuery version * Parameterized jobs get child fetching and jobs index status style for parent jobs * Completed allocs vs Running allocs in a child-job context, and fix an issue where moving from parent to parent would not reset index * Testfix and better handling empty-child-statuses-list * Parent/child test case * Dont show empty allocation-status bars for parent jobs with no children
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
from
May 6, 2024 15:24
e1e8c6c
to
fe8636c
Compare
philrenaud
force-pushed
the
bff-job-summary-fe-redux-untangle
branch
from
May 6, 2024 17:57
fe8636c
to
3877fbf
Compare
gulducat
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bring on those live updates! 👏
This was referenced May 9, 2024
This was referenced May 28, 2024
This was referenced Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new way of handling some long-needed upgrades to the Jobs Index page in the web UI:
This has also included some side-effect features that we think will be a big improvement to web UI quality of life:
Degraded
andRecovering
instead ofRunning
|Dead
|Pending
.localStorage
settings for a few new featuresGeneral methodology:
(Re-do of #19778 before I borked the rebase)