api: add missing AllocDirStats field in Go API
#20261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
type/bug
theme/api
The JSON response for the Read Stats client API includes an `AllocDirStats` field. This field is missing in the `api` package, so consumers of the Go API can't use it to read the values we're getting back from the HTTP server. Fixes: #20246
tgross
force-pushed
the
api-missing-allocdir-stats
branch
from
29504a1
to
b8856eb
Compare
gulducat
approved these changes
Apr 2, 2024
| c.DevMode = true | ||
| }) | ||
| defer s.Stop() | ||
| nodesAPI := c.Nodes() |
There was a problem hiding this comment.
ah this is one of those little "node" vs "client" battlegrounds, eh?
There was a problem hiding this comment.
Yeah c is the Go API client, and c.Nodes() is the Nodes API in the Go API client. 😀
There was a problem hiding this comment.
I was more pointing out that it hits the /client API, not /node! looks like there's no client.go to have something like c.Clients() presumably to avoid the name collision of "Nomad client" and "Nomad API client" ... so the Nodes{} (go) API on the (go) API Client{} is used to hit both the /nodes (http) API and the /client (http) API 😅
Juanadelacuesta
approved these changes
Apr 3, 2024
Co-authored-by: Daniel Bennett <[email protected]>
This was referenced Apr 3, 2024
philrenaud
pushed a commit
that referenced
this pull request
Apr 18, 2024
The JSON response for the Read Stats client API includes an `AllocDirStats` field. This field is missing in the `api` package, so consumers of the Go API can't use it to read the values we're getting back from the HTTP server. Fixes: #20246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON response for the Read Stats client API includes an
AllocDirStatsfield. This field is missing in theapipackage, so consumers of the Go API can't use it to read the values we're getting back from the HTTP server.Fixes: #20246