-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nil pointer dereference if alloc has nil Job #19972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cleroux!
This looks good. Can you run make cl
to add a changelog entry for this bug? Something like "client: Fixed a bug where corrupt client state could panic the client"
Co-authored-by: Tim Gross <[email protected]>
Thanks, @tgross! Requested changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Once CI is done I'll merge this and get it backported. Thanks @cleroux!
The failing storybook test is unrelated and is being worked on. The flaky leadership test in |
We encountered the following on one of our production hosts:
We were able to resolve the issue by deleting state.db and state.db.backup on that host.
I believe there must have been some corrupt state stored in the DB that somehow decoded to an alloc with a nil
Job
.