Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Honor job's namespace when checking distinct_hosts feasibility #19004

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[core] Honor job's namespace when checking distinct_hosts feasibility #19004

merged 2 commits into from
Nov 17, 2023

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented Nov 7, 2023 •
edited
Loading

Added test to verify original condition and that fix resolved it.

🔍 Website Preview Links

@angrycub angrycub marked this pull request as ready for review November 7, 2023 17:04
@angrycub angrycub self-assigned this Nov 7, 2023
schmichael
schmichael approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tgross
tgross approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we also add a note to the upgrade guide around this?

jrasell
jrasell approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 on the upgrade guide note and I think this PR will also need backport labels.

@angrycub
Update distinct_host feasibility checking to honor the job's
3c05518 
namespace. Fixes #9792

Added test to verify original condition and that fix resolved it.
@angrycub
Added documentation
a7d7839 
Made a note on the version upgrade guide.
Made a fix to the `constraint` page to use the <Warning> component
@angrycub angrycub added type/bug backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line theme/core stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Nov 9, 2023
@angrycub angrycub merged commit 659c094 into main Nov 17, 2023
37 of 38 checks passed
@angrycub angrycub deleted the angrycub/issue9792 branch November 17, 2023 16:25
angrycub added a commit that referenced this pull request Nov 20, 2023
@angrycub
backport of commit 659c094 (#19004) (#19130)
eb43489 
[core] Honor job's namespace when checking `distinct_hosts` feasibility
* Update distinct_host feasibility checking to honor the job's namespace. Fixes #9792
* Added test to verify original condition and that fix resolved it.
* Added documentation

Manual backport due to merge conflicts in upgrade-specific.mdx
angrycub added a commit that referenced this pull request Nov 20, 2023
@angrycub
backport of commit 659c094 (#19004) (#19129)
f17d60d 
[core] Honor job's namespace when checking `distinct_hosts` feasibility
Manual backport because of conflicts in upgrade-specific.mdx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@tgross tgross tgross approved these changes

@schmichael schmichael schmichael approved these changes

Assignees

@angrycub angrycub

Labels
backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/core type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angrycub @schmichael @tgross @jrasell