Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add prefix ID and wildcard namespace support for service info #18836

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

tgross
Copy link
Member

@tgross tgross commented Oct 23, 2023

The nomad service info command doesn't support using a wildcard namespace with a prefix match, the way that we do for many other commands. Update the command to do a prefix match list query for the services before making the get query.

Fixes: #18831

Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The `nomad service info` command doesn't support using a wildcard namespace with
a prefix match, the way that we do for many other commands. Update the command
to do a prefix match list query for the services before making the get query.

Fixes: #18831
@tgross tgross force-pushed the service-info-wildcard-namespace branch from 2772c52 to a031085 Compare October 23, 2023 15:49
@tgross
Copy link
Member Author

tgross commented Oct 23, 2023

Fixed the embarrassing bug where I was shadowing the ns variable in formatServiceListOutput 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad service does not handle globbed namespaces.
2 participants