Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observe newlines when displaying variables #17343

Merged

Conversation

philrenaud
Copy link
Contributor

Resolves #17183

pre-wrap-formatting will honour newline characters and still attempt to wrap at the appropriate point (in case of a particularly long variable with spaces, etc.)

image
image

@github-actions
Copy link

github-actions bot commented May 29, 2023

Ember Test Audit comparison

main 78047dd change
passes 1475 1475 0
failures 0 0 0
flaky 0 0 0
duration 11m 13s 754ms 12m 43s 004ms +1m 29s 250ms

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A changelog here would be nice as well 🙂

@philrenaud philrenaud force-pushed the 17183-preserve-newlines-when-showing-nomad-variables-in-ui branch from 3fbf642 to 78047dd Compare May 30, 2023 18:21
@philrenaud philrenaud merged commit 822b3ad into main May 30, 2023
@philrenaud philrenaud deleted the 17183-preserve-newlines-when-showing-nomad-variables-in-ui branch May 30, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserve newlines when showing Nomad variables in UI
3 participants