[scheduler] Honor false for distinct hosts constraint
#16907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Schurter <[email protected]>
angrycub
added
backport/1.3.x
This was referenced Apr 17, 2023
tgross
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Looks like @schmichael beat me to the punch on reviewing this, but just wanted to say LGTM and the PR description here was top notch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when checking a nodes feasibility against the
distinct_hostsconstraint, the mere presence of the constraint is sufficient to activate it; however, the documentation indicates that setting the value to false is a legitimate answer.The
jobspecHCL1 parser would look for cases where the value was set to false and strip it from the generated job specification before submission. Thejobspec2HCL2 parser writes it into the specification with the provided value whether true or false.This has the consequence of causing jobs or tasks with a distinct_hosts constraint to always act as though the value is set to true.
Fixes #13861
false