Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: default device.container_path to host_path #16811

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

schmichael
Copy link
Member

Matches docker cli behavior.

Fixes #16754

@schmichael schmichael requested review from shoenig and angrycub April 6, 2023 00:05
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,3 @@
```release-note:improvement
driver/docker: Default `devices.container_path` to `devices.host_path` like Docker's CLI.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the trailing .

Using make cl to generate these will help format them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.5.x backport to 1.5.x release line type/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker driver devices host_path accepts directory but fails to provide it to Docker container
2 participants