Do not set attributes when spawning the getter child #16791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shoenig
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Thanks for the PR @the-nando!
I believe we can eliminate the credentials() helpers altogether now as well since they aren't being used in any case. Do you mind cleaning those up as well?
And can you run make cl to add a Changelog entry for this PR?
Thanks!
|
The Does it still make sense to test for directory ownership as the getter now can only run under the same user Nomad runs? If not, I can remove the chown's assertions and cleanup the other files too.
|
|
@shoenig please have a look if it looks ok this way. Thanks! |
shoenig
pushed a commit
that referenced
this pull request
Apr 10, 2023
* Do not set attributes when spawning the getter child * Cleanup * Cleanup --------- Co-authored-by: the-nando <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
95359b8 disabled running the artifact downloader on Linux as the user
nobodybut left behind the code to set UID / GID, which are currently set as the same ones the user Nomad runs under. The current implementation however doesn't work, as described in #16789.This PR removes setting attributes altogether as they are technically non required and they'll be inherited from the parent.
Fixes #16789