[ui] Copyable server and client attribute values #16548
Conversation
philrenaud
force-pushed
the
16539-ui-make-it-easy-to-copy-values-from-clientserver-pages
branch
from
53aa8d2 to
9f35b7a
Compare
Ember Asset Size actionAs of d9cdb83 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
| import classic from 'ember-classic-decorator'; | ||
|
|
||
| @classic | ||
| @classNames('copy-button') | ||
| @classNameBindings('inset') |
There was a problem hiding this comment.
nit: There are only 6 invocations of the CopyButton component. Rather than persisting ember-classic pattern, this seems like an easy win for us to migrate to Ember Octane via a Glimmer component!
There was a problem hiding this comment.
Gave it a shot, including upgrading ember-cli-clipboard, and ran into errors. Seems not worth holding up this feature for.
There was a problem hiding this comment.
I got it up and running pretty immediately. Which errors did you run into? Do you think we'll run into similar errors on the upgrade path to Ember 4?
There was a problem hiding this comment.
Please open a PR! All look and feel was fine but no events were firing.
philrenaud
deleted the
16539-ui-make-it-easy-to-copy-values-from-clientserver-pages
branch
Resolves #16539
Adds Copy buttons to server and client attribute values:
In order to get this working within the confines of a (potentially overflow:hidden) table row, added the
@insetargument, which will modify the background to be transparent, the dom placement to be inline, and to not show a "Copied!" message and defer instead to just the checkmark icon.