Don't fail other tasks when retrying artifact get #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifact fetching may be retried and succeed, so don't set the task as dead. Fixes #1558
| @@ -61,6 +63,45 @@ func TestAllocRunner_SimpleRun(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| // TestAllocRuner_RetryArtifact ensures that if one task in a task group is | |||
| // retrying fetching an artifact, other tasks in the the group should be able | |||
| // to proceed. See #1558 | |||
There was a problem hiding this comment.
We generally don't do code references back to github issues
|
LGTM after comments + tests passing |
Web task should run to completion successfully while the `bad` task is retrying artifact downloads.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact fetching may be retried and succeed, so don't set the task
as dead.
Fixes #1558