cli: nomad login command should not require a -type flag and should respect default auth method #16504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default auth method. Closes #16501.
pkazmierczak
changed the title
jrasell
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
LGTM, with a tiny grammar comment change. It might be worth pinging @mikenomitch to double check he is cool with the UX change.
It would also be worth preparing PR's for any tutorials that also need updating based on this, so they can be released at the right time.
Co-authored-by: James Rasell <[email protected]>
mikenomitch
approved these changes
Mar 17, 2023
pkazmierczak
added a commit
that referenced
this pull request
Mar 17, 2023
…espect default auth method (#16504) nomad login command does not need to know ACL Auth Method's type, since all method names are unique. Co-authored-by: James Rasell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nomad logincommand does not need to know ACL Auth Method's type, since all method names are unique. I discovered this while fixing a bug in whichloginignored the existence of default auth method and errored when users didn't provide a method name or type. I believe this bug comes from the fact that originally we intended to have default-per-type design, and later we decided it's better UX to have global-default auth methods.Closes #16501.