Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: variables GetItems method causes panic if variable does not exist #16236

Closed
shoenig opened this issue Feb 20, 2023 · 0 comments · Fixed by #16237
Closed

api: variables GetItems method causes panic if variable does not exist #16236

shoenig opened this issue Feb 20, 2023 · 0 comments · Fixed by #16237
Labels
theme/api HTTP API and SDK issues type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Feb 20, 2023

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x10c8a61]

goroutine 1 [running]:
github.com/hashicorp/nomad/api.(*Variables).GetItems(0xc000d7eeb8?, {0x7fffef67316b?, 0x1?}, 0x4b79476?)
	/home/shoenig/Work/go/nomad/api/variables.go:174 +0xe1
github.com/traefik/traefik/v2/pkg/provider/acme.get[...](0xc0013cda40, {0x7fffef67316b, 0xc}, {0x4b80e20, 0x7})
	/home/shoenig/Work/go/traefik/pkg/provider/acme/nomad_store.go:128 +0x77
github.com/traefik/traefik/v2/pkg/provider/acme.(*NomadStore).GetAccount(0xc0013cda40, {0xc000bce8ee, 0x2})
	/home/shoenig/Work/go/traefik/pkg/provider/acme/nomad_store.go:66 +0x2bc

This should return an error, but we'll have to fix #16234 first

@shoenig shoenig added type/bug theme/api HTTP API and SDK issues labels Feb 20, 2023
@shoenig shoenig changed the title api: variables GetItems methods causes panic if variable does not exist api: variables GetItems method causes panic if variable does not exist Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/api HTTP API and SDK issues type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant