Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add option to configure CSIVolumeClaimGCInterval #16195

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

visweshs-cb
Copy link
Contributor

@visweshs-cb visweshs-cb commented Feb 16, 2023

The default setting is 5 minutes. If we lose an instance using an EBS volume with the CSI EBS volume plugin, it takes up to 5 minutes before the claims are GC'ed and we can get the job rescheduled. We would like to be able to configure this to be lower.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 16, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @visweshs123! This looks great, thanks for the PR. I've pushed an extra commit with changelog, docs update, a minor bit of validation, and a test fix. I'll get this merged once CI is green and this will ship in Nomad 1.5.0 GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants