artifact: protect against unbounded artifact decompression (1.5.0) #16151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
changed the title
Starting with 1.5.0, set defaut values for artifact decompression limits. artifact.decompression_size_limit (default "100GB") - the maximum amount of data that will be decompressed before triggering an error and cancelling the operation artifact.decompression_file_count_limit (default 4096) - the maximum number of files that will be decompressed before triggering an error and cancelling the operation.
shoenig
force-pushed
the
15x-go-getter-limits
branch
from
29a4abf to
c4e517a
Compare
tgross
approved these changes
Feb 13, 2023
| @@ -166,6 +186,22 @@ func (a *ArtifactConfig) Validate() error { | |||
| return fmt.Errorf("s3_timeout must be > 0") | |||
| } | |||
|
|
|||
| if a.DecompressionFileCountLimit == nil { | |||
There was a problem hiding this comment.
Can this value (and DecompressionSizeLimit on line 192) ever be nil in 1.5.0? If it's not set in the user's configuration, we should be falling back to the default value. Is this just belt-and-suspenders against a NPE when we ParseBytes later?
There was a problem hiding this comment.
Indeed it "can't" ever be nil because we only create one of these from a DefaultConfig() helper; the validation here should not set a default at all I think, and simply fail the validation if the value is nil.
Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a forward-port of #16126.
Targets main/1.5.0 only.
Starting with 1.5.0, we set default values for artifact decompression limits.
Note: these limits simply "seem reasonable". Download sizes are already limited to 100GB by default, and 4096 seems like enough files for most use cases without being unbounded.