Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui, helios] Toast Component #16099

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Conversation

philrenaud
Copy link
Contributor

Adds toast component styles from Helios to the Nomad Web UI

image

Resolves #16095

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Ember Asset Size action

As of f78f14d

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +241 B +30 B

Files that got Smaller 🎉:

File raw gzip
nomad-ui.css -966 B -207 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Ember Test Audit comparison

main f78f14d change
passes 1467 1467 0
failures 0 0 0
flaky 0 0 0
duration 10m 53s 212ms 10m 54s 128ms +916ms

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use this as a chance to update flashMessages? I've always been annoyed with the API and how verbose we need to be when using it. This is could be a great opportunity to make a simple method on the service like:

showMessage(type, config) {
  this.flashMessages.add({
    color: type,
    destroyOnClick: false,
    timeout: 5000,
    ...config
  })
}

This would save ~10 lines of code every time we use this in the application.

@philrenaud philrenaud force-pushed the 16095-ui-helios-toast-component branch from 9e5d2c8 to 4d7b240 Compare February 9, 2023 20:23
@philrenaud philrenaud force-pushed the 16095-ui-helios-toast-component branch from f6bbda0 to f78f14d Compare February 10, 2023 15:38
@philrenaud philrenaud merged commit f88e3b0 into main Mar 2, 2023
@philrenaud philrenaud deleted the 16095-ui-helios-toast-component branch March 2, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui, helios] Toast component
2 participants