-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui, helios] Toast Component #16099
[ui, helios] Toast Component #16099
Conversation
Ember Asset Size actionAs of f78f14d Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
139be03
to
0292e9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use this as a chance to update flashMessages
? I've always been annoyed with the API and how verbose we need to be when using it. This is could be a great opportunity to make a simple method on the service like:
showMessage(type, config) {
this.flashMessages.add({
color: type,
destroyOnClick: false,
timeout: 5000,
...config
})
}
This would save ~10 lines of code every time we use this in the application.
9e5d2c8
to
4d7b240
Compare
4d7b240
to
0c284a5
Compare
f6bbda0
to
f78f14d
Compare
Adds toast component styles from Helios to the Nomad Web UI
Resolves #16095