Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: remove deprecated uses of rand.Seed #16074

Merged
merged 3 commits into from
Feb 7, 2023
Merged

main: remove deprecated uses of rand.Seed #16074

merged 3 commits into from
Feb 7, 2023

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Feb 7, 2023

go1.20 deprecates rand.Seed, and seeds the rand package automatically. Remove cases where we seed the random package, and cleanup the one test case where we intentionally create a known random source.

https://pkg.go.dev/math/rand#Seed
https://go.dev/doc/go1.20

go1.20 deprecates rand.Seed, and seeds the rand package
automatically. Remove cases where we seed the random package,
and cleanup the one case where we intentionally create a
known random source.
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Checked locally also:

$ ag "rand.Seed" |wc -l 
       0

@shoenig shoenig merged commit b21aeb8 into main Feb 7, 2023
@shoenig shoenig deleted the no-rand-seed branch February 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants