Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label for the Web UI #16006

Merged
merged 6 commits into from
Feb 2, 2023
Merged

Label for the Web UI #16006

merged 6 commits into from
Feb 2, 2023

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Feb 1, 2023

Resolves #10813

Adds a label block to the Nomad agent config:

ui {
  label {
    text             = "Miami Datacenter"
    background_color = "palegreen"
    text_color       = "hotpink"
  }
}

image

Also shows up in the <title> attribute for browser tabs etc.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Ember Asset Size action

As of 47b1228

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +811 B +220 B
nomad-ui.css +131 B +6 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Ember Test Audit comparison

main 47b1228 change
passes 1453 1453 0
failures 0 1 +1
flaky 0 0 0
duration 11m 05s 715ms 000ms -11m 05s 715ms

@philrenaud philrenaud marked this pull request as ready for review February 1, 2023 18:10
'1.1.0-beta',
'1.0.2-alpha+ent',
...provide(5, faker.system.semver),
];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our pre-commit hook caught this file and did some prettifying. Lines 22-26 are the only practically changed ones.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, its super annoying. Anytime I notice this I make sure to git commit --no-verify.

Its probably worth tackling some infrastructure stuff like this for developer quality of life.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 388764a:

  • Integration | Utility | exec-command-editor-xterm-adapter: it supports typing ^U to delete the entire command

@chrisvanmeer chrisvanmeer mentioned this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Customization
3 participants