sso: login workflow implementation #15816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binder provides an interface for binding claims and ACL roles/policies of Nomad.
This adds new OIDC endpoints on the RPC endpoint. These two RPCs handle generating the OIDC provider URL and then completing the login by exchanging the provider token with an internal Nomad token. The RPC endpoints both do double forwarding. The initial forward is to ensure we are talking to the regional leader; the second then takes into account whether the auth method generates local or global tokens. If it creates global tokens, we must then forward onto the federated regional leader.
The OIDC provider cache is used by the RPC handler as the OIDC implementation keeps long lived processes running. These process include connections to the remote OIDC provider. The Callback server is used by the CLI and starts when the login command is triggered. This callback server includes success HTML which is displayed when the user successfully logs into the remote OIDC provider.
* Updated UI to handle OIDC method changes * Remove redundant store unload call
sso: add OIDC login RPC, HTTP, and CLI workflow
Ember Asset Size actionAs of 54cc797 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
jrasell
force-pushed
the
sso/gh-13120-oidc-login
branch
from
c93fcd8 to
b0d633f
Compare
jrasell
force-pushed
the
sso/gh-13120-oidc-login
branch
from
b0d633f to
54cc797
Compare
Ember Test Audit comparison
|
pkazmierczak
approved these changes
Jan 18, 2023
|
@jrasell James, I have nothing to add except to thank you for this feature. I was waiting for this since v0.1 😁 ❤️ hashicorp rocks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13120
All code has been previously reviewed.
Code represents the full OIDC workflow integration and has been tested by the project team. Once this is merged, all followup PRs should target main. I will also cleanup old SSO branches once merged.
Note: this commit updates the semgrep rule to account for known unauthenticated OIDC RPCs. It's small but is worth a quick glance at.