artifact: enable inheriting environment variables from client #15514
Conversation
shoenig
force-pushed
the
f-getter-environment
branch
from
e2b5d8a to
be57726
Compare
shoenig
changed the title
This PR adds client configuration for specifying environment variables that
should be inherited by the artifact sandbox process from the Nomad Client agent.
Most users should not need to set these values but the configuration is provided
to ensure backwards compatability. Configuration of go-getter should ideally be
done through the artifact block in a jobspec task.
e.g.
```hcl
client {
artifact {
set_environment_variables = "TMPDIR,GIT_SSH_OPTS"
}
}
```
Closes #15498
shoenig
force-pushed
the
f-getter-environment
branch
from
be57726 to
96608ce
Compare
| // SetEnvironmentVariables is a comma-separated list of environment | ||
| // variable names to inherit from the Nomad Client and set in the artifact | ||
| // download sandbox process. | ||
| SetEnvironmentVariables *string `hcl:"set_environment_variables"` |
There was a problem hiding this comment.
On the name "set": is there future in which we might want to let users set specific env vars, rather than having them inherit from the client?
There was a problem hiding this comment.
I think we can continue using this field to support setting custom values, just by interpreting '=' as key+value, e.g.
set_environment_variables = "BLAH,PATH=/opt/custom/bin"
But that would be beyond compatibility support, so that's a PR for another day
| - `set_environment_variables` `(string:"")` - Specifies a comma separated list | ||
| of environment variables that should be inherited by the artifact sandbox from | ||
| the Nomad client's environment. |
There was a problem hiding this comment.
Do we want to call out the default variables here so that people don't think they need to add PATH?
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds client configuration for specifying environment variables that
should be inherited by the artifact sandbox process from the Nomad Client agent.
Most users should not need to set these values but the configuration is provided
to ensure backwards compatability. Configuration of go-getter should ideally be
done through the artifact block in a jobspec task.
e.g.
Closes #15497