Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: ensure all request body decode error return a 400 status code. #15252

Merged
merged 2 commits into from
Nov 18, 2022
Merged

api: ensure all request body decode error return a 400 status code. #15252

merged 2 commits into from
Nov 18, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Nov 15, 2022 •
edited
Loading

Related to #15253 but split, so this PR can be back-ported further.

@jrasell jrasell marked this pull request as draft November 15, 2022 14:11
@jrasell jrasell mentioned this pull request Nov 15, 2022
Merged
@jrasell jrasell self-assigned this Nov 15, 2022
@jrasell jrasell requested review from lgfa29 and angrycub November 15, 2022 14:29
@jrasell jrasell added backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Nov 15, 2022
@jrasell jrasell marked this pull request as ready for review November 15, 2022 14:30
lgfa29
lgfa29 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad request, no 🍩 for you

@jrasell jrasell merged commit c495cd9 into main Nov 18, 2022
@jrasell jrasell deleted the jrasell/b-http-endpoint-ensure-decode-400-error-resp branch November 18, 2022 16:04
This was referenced Nov 18, 2022
Merged
Merged
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@jrasell jrasell

Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrasell @lgfa29