Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: allow tokens to read policies linked via roles to the token. #14982

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 20, 2022

ACL tokens are granted permissions either by direct policy links or via ACL role links. Callers should therefore be able to read policies directly assigned to the caller token or indirectly by ACL role links.

ACL tokens are granted permissions eithe rby direct policy links
or via ACL role links. Callers should therefore be able to read
policies directly assigned to the caller token or indirectly by
ACL role links.
@jrasell jrasell requested review from tgross, shoenig and lgfa29 October 20, 2022 14:47
@jrasell jrasell self-assigned this Oct 20, 2022
@jrasell jrasell added the backport/1.4.x backport to 1.4.x release line label Oct 20, 2022
@jrasell jrasell added this to the 1.4.2 milestone Oct 20, 2022
@jrasell jrasell marked this pull request as ready for review October 20, 2022 14:47
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one thought

nomad/acl_endpoint.go Show resolved Hide resolved
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants