Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add killing event and mark task as not running when killed #1457

Merged
merged 1 commit into from
Jul 23, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Jul 21, 2016

Task "redis" is "dead"
Task Resources
CPU  Memory   Disk     IOPS  Addresses
500  256 MiB  300 MiB  0     db: 127.0.0.1:43968

Recent Events:
Time                   Type      Description
07/20/16 09:20:39 UTC  Killed    Task successfully killed
07/20/16 09:20:39 UTC  Killing   Sent interupt. Waiting 5s before force killing
07/20/16 09:20:35 UTC  Started   Task started by client
07/20/16 09:20:31 UTC  Received  Task received by client

@diptanu
Copy link
Contributor

diptanu commented Jul 22, 2016

@dadgar With these changes does the Task Runner unblocks after calling the destroy on the driver? I think it will still block since the handle destroy and the subsequent call the to destroy method on the driver is called synchronously.

@dadgar
Copy link
Contributor Author

dadgar commented Jul 22, 2016

@diptanu Yeah it blocks but that behavior is correct. We had bad locking at the alloc_runner level which was causing the issues you saw. This PR fixes them #1454

@diptanu
Copy link
Contributor

diptanu commented Jul 22, 2016

@dadgar I see, that makes sense. LGTM

@dadgar dadgar merged commit 590e5e9 into master Jul 23, 2016
@dadgar dadgar deleted the f-kill-event branch July 23, 2016 00:33
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants