Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: interpolate task env in config values #14445

Merged
merged 3 commits into from
Sep 2, 2022
Merged

connect: interpolate task env in config values #14445

merged 3 commits into from
Sep 2, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Sep 1, 2022

When configuring Consul Service Mesh, it's sometimes necessary to
provide dynamic value that are only known to Nomad at runtime. By
interpolating configuration values (in addition to configuration keys),
user are able to pass these dynamic values to Consul from their Nomad
jobs.

Closes #14403

@lgfa29
connect: interpolate task env in config values
00c5a8b 
When configuring Consul Service Mesh, it's sometimes necessary to
provide dynamic value that are only known to Nomad at runtime. By
interpolating configuration values (in addition to configuration keys),
user are able to pass these dynamic values to Consul from their Nomad
jobs.
@lgfa29 lgfa29 requested review from shoenig and jrasell September 1, 2022 20:38
@lgfa29 lgfa29 mentioned this pull request Sep 1, 2022
Closed
jrasell
jrasell approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we want to add any detail to the docs to mention this; seems quite a subtle enhancement which might be hard for users to find.

@lgfa29 lgfa29 merged commit 7d88937 into main Sep 2, 2022
@lgfa29 lgfa29 deleted the f-interpolate-service-config-values branch September 2, 2022 19:00
@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label Sep 2, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Sep 2, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees
No one assigned
Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad job with envoy escape hatch has no dynamic port interpolation available
2 participants
@lgfa29 @jrasell