[ui] Allocation route services table: show task-level services #14199
Conversation
Ember Asset Size actionAs of f14031c Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
| @@ -47,10 +48,22 @@ export default class IndexController extends Controller.extend(Sortable) { | |||
| } | |||
|
|
|||
| @computed('[email protected]') | |||
| get services() { | |||
| get groupServices() { | |||
| return (this.get('model.taskGroup.services') || []).sortBy('name'); | |||
There was a problem hiding this comment.
suggestion: This is an asynchronous request. allocations.allocation does not load the TaskGroup and this should trigger a fetch request. TaskGroup can fail as a request here and we won't notify the user.
| return (this.get('model.taskGroup.services') || []).sortBy('name'); | ||
| } | ||
|
|
||
| @computed('[email protected]') |
There was a problem hiding this comment.
question: Is this the correct dependent key?
Hey @ChaiWithJai — you're correct that the Service Discovery UI feature will be realtime. However, you might call this pre-work: the existing services table, currently on the allocations page in the UI, does not show any task-level services. All this PR seeks to do is to extend that already-existing functionality to include task-level services, too. |
philrenaud
deleted the
14198-show-task-level-services-on-the-alloc-page
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
(resolves #14198)
Adds service fragments to allocations and union taskGroup and task services. Works with both Consul and Nomad service providers.
Before (Nomad)
After (Nomad)
After (Consul)