Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentinel: add support for Nomad ACL Token and Namespace #14171

Merged
merged 2 commits into from
Aug 18, 2022
Merged

sentinel: add support for Nomad ACL Token and Namespace #14171

merged 2 commits into from
Aug 18, 2022

Conversation

DerekStrickland
Copy link
Contributor

This PR synchronizes the Sentinel related changes required to support Nomad ACL Tokens and Namespaces when writing policies.

@DerekStrickland DerekStrickland added type/enhancement theme/enterprise Issues related to Enterprise features labels Aug 17, 2022
@DerekStrickland DerekStrickland self-assigned this Aug 17, 2022
@DerekStrickland DerekStrickland added this to the 1.3.x milestone Aug 17, 2022
pkazmierczak
pkazmierczak approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

lgfa29
lgfa29 approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need the changelog entry here as well since it's generated from the OSS repo.

@DerekStrickland
Copy link
Contributor Author

We'll need the changelog entry here as well since it's generated from the OSS repo.

I wondered about that. Added. Thanks!

@DerekStrickland DerekStrickland merged commit a67bdd1 into main Aug 18, 2022
@DerekStrickland DerekStrickland deleted the f-extend-sentinel-with-token-and-namespace branch August 18, 2022 20:33
@DerekStrickland DerekStrickland added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Aug 23, 2022
This was referenced Aug 23, 2022
Merged
Merged
Merged
@lgfa29 lgfa29 modified the milestones: 1.3.x, 1.3.4 Aug 23, 2022
@lgfa29 lgfa29 removed backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line labels Aug 23, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgfa29 lgfa29 lgfa29 approved these changes

@pkazmierczak pkazmierczak pkazmierczak approved these changes

Assignees

@DerekStrickland DerekStrickland

Labels
backport/1.3.x backport to 1.3.x release line theme/enterprise Issues related to Enterprise features type/enhancement
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@DerekStrickland @pkazmierczak @lgfa29