Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command/job_stop: accept multiple jobs, stop concurrently #12582

Merged
merged 3 commits into from
Dec 16, 2022
Merged

command/job_stop: accept multiple jobs, stop concurrently #12582

merged 3 commits into from
Dec 16, 2022

Conversation

danishprakash
Copy link
Contributor

@danishprakash danishprakash commented Apr 15, 2022 •
edited
Loading

Closes #2390

Signed-off-by: danishprakash [email protected]

danishprakash
danishprakash commented Apr 15, 2022
View reviewed changes
command/job_stop.go Show resolved Hide resolved
command/job_stop.go Outdated Show resolved Hide resolved
command/job_stop.go Show resolved Hide resolved
command/job_stop.go Show resolved Hide resolved
command/job_stop.go Outdated Show resolved Hide resolved
@danishprakash
Copy link
Contributor Author

Hey, @schmichael, I've left a few questions about this draft implementation, can you take a look when you have a moment? Thanks.

@mikenomitch
Copy link
Contributor

Hey @danishprakash, sorry we didn't see this initially somehow. I'll poke at @schmichael or one of the other engineers to take a look!

@schmichael, poke.

@schmichael schmichael self-requested a review April 26, 2022 20:40
@schmichael
Copy link
Member

Sorry for the delay @danishprakash! Looking good so far! I'll try to be faster to respond after your next update.

@danishprakash danishprakash force-pushed the concurrent-job-stop branch from 2583b85 to 4d0f320 Compare May 3, 2022 14:00
danishprakash
danishprakash commented May 3, 2022
View reviewed changes
command/job_stop.go Outdated Show resolved Hide resolved
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from 4d0f320 to ba47aae Compare May 19, 2022 04:08
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from ba47aae to c8b731e Compare June 4, 2022 08:52
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from c8b731e to 724de69 Compare June 4, 2022 13:26
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from 724de69 to 86549f7 Compare June 4, 2022 15:34
@danishprakash danishprakash marked this pull request as ready for review June 6, 2022 06:53
schmichael
schmichael approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs a changelog entry and docs update. I can add those quick.

command/job_stop_test.go Outdated Show resolved Hide resolved
command/job_stop_test.go Show resolved Hide resolved
command/job_stop_test.go Show resolved Hide resolved
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from 83c8d55 to de99137 Compare June 7, 2022 01:49
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from de99137 to 59dc029 Compare June 7, 2022 10:09
@danishprakash danishprakash force-pushed the concurrent-job-stop branch from 59dc029 to b57a0e9 Compare June 7, 2022 10:48
@vercel
Copy link

vercel bot commented Dec 16, 2022

@schmichael is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@schmichael
Copy link
Member

Merging! Thanks for the contribution @danishprakash. I am terribly sorry this took so long to merge! It will ship in Nomad 1.5.

@schmichael schmichael merged commit 16401b8 into hashicorp:main Dec 16, 2022
@shoenig shoenig mentioned this pull request Dec 21, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikenomitch mikenomitch mikenomitch left review comments

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
theme/cli
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad CLI should allow multiple jobs in stop command
4 participants
@danishprakash @mikenomitch @schmichael @tgross